From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@infradead.org (Christoph Hellwig) Date: Tue, 17 Jul 2018 05:42:52 -0700 Subject: [PATCH v3 1/1] nvme: Ensure forward progress during Admin passthru In-Reply-To: <20180716220940.GA26925@localhost.localdomain> References: <20180622195914.18575-1-scott.bauer@intel.com> <20180629190328.2096-1-scott.bauer@intel.com> <20180629202350.GB13865@localhost.localdomain> <20180716220940.GA26925@localhost.localdomain> Message-ID: <20180717124252.GA14724@infradead.org> On Mon, Jul 16, 2018@04:09:40PM -0600, Keith Busch wrote: > On Fri, Jun 29, 2018@02:23:50PM -0600, Keith Busch wrote: > > On Fri, Jun 29, 2018@01:03:28PM -0600, Scott Bauer wrote: > > > If the controller supports effects and goes down during > > > the passthru admin command we will deadlock during > > > namespace revalidation. > > > > > > [ 363.488275] INFO: task kworker/u16:5:231 blocked for more than 120 seconds. > > > [ 363.488290] Not tainted 4.17.0+ #2 > > > [ 363.488296] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. > > > [ 363.488303] kworker/u16:5 D 0 231 2 0x80000000 > > > [ 363.488331] Workqueue: nvme-reset-wq nvme_reset_work [nvme] > > > [ 363.488338] Call Trace: > > > [ 363.488385] schedule+0x75/0x190 > > > [ 363.488396] rwsem_down_read_failed+0x1c3/0x2f0 > > > [ 363.488481] call_rwsem_down_read_failed+0x14/0x30 > > > [ 363.488504] down_read+0x1d/0x80 > > > [ 363.488523] nvme_stop_queues+0x1e/0xa0 [nvme_core] > > > [ 363.488536] nvme_dev_disable+0xae4/0x1620 [nvme] > > > [ 363.488614] nvme_reset_work+0xd1e/0x49d9 [nvme] > > > [ 363.488911] process_one_work+0x81a/0x1400 > > > [ 363.488934] worker_thread+0x87/0xe80 > > > [ 363.488955] kthread+0x2db/0x390 > > > [ 363.488977] ret_from_fork+0x35/0x40 > > > > > > Fixes: 84fef62d135b6 ("nvme: check admin passthru command effects") > > > > > > Signed-off-by: Scott Bauer > > > > Looks good to me. > > > > Reviewed-by: Keith Busch > > Christoph, > Could we get this one queued up for next? Will look at it ASAP.