From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme: register ns_id attributes as default sysfs groups
Date: Tue, 17 Jul 2018 15:12:39 +0200 [thread overview]
Message-ID: <20180717131239.GA13582@lst.de> (raw)
In-Reply-To: <20180716103721.96363-1-hare@suse.de>
On Mon, Jul 16, 2018@12:37:21PM +0200, Hannes Reinecke wrote:
> We should be registering the ns_id attributes as default sysfs groups,
> otherwise we have a race condition between nvme_mpath_add_disk() and
> nvme_mpath_remove_disk() which will lead to a kobject warning during
> rapid connect/disconnect cycles.
>
> Reported-by: James Smart <james.smart at broadcom.com>
> Signed-off-by: Hannes Reinecke <hare at suse.com>
> ---
Didn't Martin Wilck habe a patch to pass the default attribute
group to an add_disk variant? We've been waiting for him to just
clean it up a bit, and it would be a lot less ugly than opencoding
the device model details in the callers.
next prev parent reply other threads:[~2018-07-17 13:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 10:37 [PATCH] nvme: register ns_id attributes as default sysfs groups Hannes Reinecke
2018-07-16 11:00 ` Sagi Grimberg
2018-07-17 13:12 ` Christoph Hellwig [this message]
2018-07-17 13:20 ` Hannes Reinecke
2018-07-20 14:50 ` Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717131239.GA13582@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox