From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 1/2] blk-mq: export setting request completion state
Date: Thu, 19 Jul 2018 15:26:17 -0600 [thread overview]
Message-ID: <20180719212618.2406-1-keith.busch@intel.com> (raw)
This is preparing for drivers that want to directly alter the state of
their requests. No functional change here.
Signed-off-by: Keith Busch <keith.busch at intel.com>
---
block/blk-mq.c | 4 +---
include/linux/blk-mq.h | 9 +++++++++
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 22326612a5d3..f50559718b71 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -558,10 +558,8 @@ static void __blk_mq_complete_request(struct request *rq)
bool shared = false;
int cpu;
- if (cmpxchg(&rq->state, MQ_RQ_IN_FLIGHT, MQ_RQ_COMPLETE) !=
- MQ_RQ_IN_FLIGHT)
+ if (blk_mq_mark_complete(rq))
return;
-
if (rq->internal_tag != -1)
blk_mq_sched_completed_request(rq);
diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
index 9b0fd11ce89a..0ae115e95476 100644
--- a/include/linux/blk-mq.h
+++ b/include/linux/blk-mq.h
@@ -289,6 +289,15 @@ void blk_mq_update_nr_hw_queues(struct blk_mq_tag_set *set, int nr_hw_queues);
void blk_mq_quiesce_queue_nowait(struct request_queue *q);
+/*
+ * Returns true if request was not in flight.
+ */
+static inline bool blk_mq_mark_complete(struct request *rq)
+{
+ return (cmpxchg(&rq->state, MQ_RQ_IN_FLIGHT, MQ_RQ_COMPLETE) !=
+ MQ_RQ_IN_FLIGHT);
+}
+
/*
* Driver command data is immediately after the request. So subtract request
* size to get back to the original request, add request size to get the PDU.
--
2.14.4
next reply other threads:[~2018-07-19 21:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 21:26 Keith Busch [this message]
2018-07-19 21:26 ` [PATCH 2/2] scsi: set timed out out mq requests to complete Keith Busch
2018-07-20 6:52 ` Johannes Thumshirn
2018-07-20 14:05 ` Keith Busch
2018-07-20 14:41 ` Christoph Hellwig
2018-07-20 14:50 ` Keith Busch
2018-07-20 15:12 ` Bart Van Assche
2018-07-20 15:56 ` Keith Busch
2018-07-20 16:03 ` Bart Van Assche
2018-07-20 16:12 ` Keith Busch
2018-07-20 16:20 ` Bart Van Assche
2018-07-20 16:23 ` Keith Busch
2018-07-20 16:45 ` Bart Van Assche
2018-07-20 17:24 ` Keith Busch
2018-07-23 8:12 ` hch
2018-07-23 13:59 ` Bart Van Assche
2018-07-23 14:04 ` Keith Busch
2018-07-23 8:09 ` [PATCH 1/2] blk-mq: export setting request completion state Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719212618.2406-1-keith.busch@intel.com \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox