From: hch@lst.de (Christoph Hellwig)
Subject: [PATCHv2 2/2] scsi: set timed out out mq requests to complete
Date: Tue, 24 Jul 2018 09:56:47 +0200 [thread overview]
Message-ID: <20180724075646.GC7859@lst.de> (raw)
In-Reply-To: <20180723143751.10843-2-keith.busch@intel.com>
On Mon, Jul 23, 2018@08:37:51AM -0600, Keith Busch wrote:
> The scsi block layer requires requests claimed by the error handling be
> completed by the error handler. A previous commit allowed completions
> to proceed for blk-mq, breaking that assumption.
>
> This patch prevents completions that may race with the timeout handler
> by marking the state to complete, restoring the previous behavior.
>
> Fixes: 12f5b931 ("blk-mq: Remove generation seqeunce")
> Signed-off-by: Keith Busch <keith.busch at intel.com>
Looks good enough (reluctantly) for this merge window:
Reviewed-by: Christoph Hellwig <hch at lst.de>
next prev parent reply other threads:[~2018-07-24 7:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 14:37 [PATCHv2 1/2] blk-mq: export setting request completion state Keith Busch
2018-07-23 14:37 ` [PATCHv2 2/2] scsi: set timed out out mq requests to complete Keith Busch
2018-07-24 7:56 ` Christoph Hellwig [this message]
2018-07-24 22:46 ` Bart Van Assche
2018-07-25 1:15 ` Keith Busch
2018-07-25 1:56 ` Douglas Gilbert
2018-07-25 2:48 ` Keith Busch
2018-07-25 15:52 ` Bart Van Assche
2018-07-25 16:48 ` Keith Busch
2018-07-24 7:56 ` [PATCHv2 1/2] blk-mq: export setting request completion state Christoph Hellwig
2018-07-24 20:42 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724075646.GC7859@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).