From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/2] block: move dif_prepare/dif_complete functions to block layer
Date: Tue, 24 Jul 2018 09:57:30 +0200 [thread overview]
Message-ID: <20180724075730.GD7859@lst.de> (raw)
In-Reply-To: <yq1bmax5rfl.fsf@oracle.com>
On Mon, Jul 23, 2018@09:54:38PM -0400, Martin K. Petersen wrote:
>
> Christoph,
>
> >> +void blk_integrity_dif_prepare(struct request *rq, u8 protection_type,
> >> + u32 ref_tag)
> >> +{
> >
> > Maybe call this blk_t10_pi_prepare?
>
> The rest of these functions have a blk_integrity_ prefix. So either
> stick with that or put the functions in t10-pi.c and use a t10_pi_
> prefix.
Yes, I suggested moving it somewhere in my reply.
next prev parent reply other threads:[~2018-07-24 7:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-22 9:49 [PATCH 1/2] block: move dif_prepare/dif_complete functions to block layer Max Gurtovoy
2018-07-22 9:49 ` [PATCH 2/2] nvme: use blk API to remap ref tags for IOs with metadata Max Gurtovoy
2018-07-23 7:33 ` Christoph Hellwig
2018-07-23 7:28 ` [PATCH 1/2] block: move dif_prepare/dif_complete functions to block layer Christoph Hellwig
2018-07-24 1:54 ` Martin K. Petersen
2018-07-24 7:57 ` Christoph Hellwig [this message]
2018-07-24 12:01 ` Max Gurtovoy
2018-07-23 14:02 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724075730.GD7859@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).