From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@lst.de (Christoph Hellwig) Date: Tue, 24 Jul 2018 09:57:30 +0200 Subject: [PATCH 1/2] block: move dif_prepare/dif_complete functions to block layer In-Reply-To: References: <1532252998-2375-1-git-send-email-maxg@mellanox.com> <20180723072854.GA18365@lst.de> Message-ID: <20180724075730.GD7859@lst.de> On Mon, Jul 23, 2018@09:54:38PM -0400, Martin K. Petersen wrote: > > Christoph, > > >> +void blk_integrity_dif_prepare(struct request *rq, u8 protection_type, > >> + u32 ref_tag) > >> +{ > > > > Maybe call this blk_t10_pi_prepare? > > The rest of these functions have a blk_integrity_ prefix. So either > stick with that or put the functions in t10-pi.c and use a t10_pi_ > prefix. Yes, I suggested moving it somewhere in my reply.