From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 2/9] nvme.h: add ANA definitions
Date: Wed, 25 Jul 2018 06:58:03 +0200 [thread overview]
Message-ID: <20180725045803.GB10905@lst.de> (raw)
In-Reply-To: <BYAPR04MB4502926670E37116CB7B6BEF86540@BYAPR04MB4502.namprd04.prod.outlook.com>
> +struct nvme_ana_group_desc {
> +?????? __le32? grpid;
> +?????? __le32? nnsids;
> +?????? __le64? chgcnt;
> +?????? __u8??? state;
> +?????? __u8??? rsvd17[7];
>
> [CK] From Figure 52a: ANA Group Descriptor format:-
>
> 31:17: Reserved.
>
> 35:32: Namespace Identifier 0: The Namespace Identifier of the first namespace that is a member of
> this ANA Group.
>
> So we have to change the Index of rsvd17 to 15?
The reserved fields in nvme are usually named after the index where they
start, not their length. This reserved spae is at byte 17, so I think
we are ok.
next prev parent reply other threads:[~2018-07-25 4:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 11:50 draft ANA support v5 Christoph Hellwig
2018-07-24 11:50 ` [PATCH 1/9] nvme.h: add support for the log specific field Christoph Hellwig
2018-07-24 11:50 ` [PATCH 2/9] nvme.h: add ANA definitions Christoph Hellwig
2018-07-25 0:24 ` Chaitanya Kulkarni
2018-07-25 4:58 ` Christoph Hellwig [this message]
2018-07-24 11:50 ` [PATCH 3/9] nvme: simplify the API for getting log pages Christoph Hellwig
2018-07-24 11:50 ` [PATCH 4/9] nvme: remove nvme_req_needs_failover Christoph Hellwig
2018-07-24 11:50 ` [PATCH 5/9] nvme: add ANA support Christoph Hellwig
2018-07-26 2:00 ` Martin K. Petersen
2018-07-26 11:34 ` Johannes Thumshirn
2018-07-24 11:50 ` [PATCH 6/9] nvmet: keep a port pointer in nvmet_ctrl Christoph Hellwig
2018-07-26 11:34 ` Johannes Thumshirn
2018-07-24 11:50 ` [PATCH 7/9] nvmet: track and limit the number of namespaces per subsystem Christoph Hellwig
2018-07-24 11:50 ` [PATCH 8/9] nvmet: add minimal ANA support Christoph Hellwig
2018-07-26 11:34 ` Johannes Thumshirn
2018-07-24 11:50 ` [PATCH 9/9] nvmet: support configuring ANA groups Christoph Hellwig
2018-07-26 11:34 ` Johannes Thumshirn
2018-07-24 15:56 ` draft ANA support v5 Keith Busch
2018-07-26 2:02 ` Martin K. Petersen
2018-07-26 7:45 ` Hannes Reinecke
-- strict thread matches above, loose matches on Subject: below --
2018-07-26 15:34 draft ANA support v6 Christoph Hellwig
2018-07-26 15:34 ` [PATCH 2/9] nvme.h: add ANA definitions Christoph Hellwig
2018-06-01 7:11 draft ANA support v2 Christoph Hellwig
2018-06-01 7:11 ` [PATCH 2/9] nvme.h: add ANA definitions Christoph Hellwig
2018-06-03 12:27 ` Sagi Grimberg
2018-06-04 6:30 ` Hannes Reinecke
2018-06-04 11:58 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180725045803.GB10905@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).