Q: Status of ANA patches

Q: Status of ANA patches

[Hannes Reinecke]

Hi Christoph,

do you have any timeline for the ANA patches?
 From my last testing they look good so far; the only missing bit is a 
missing configfs entry for the actual ANATT value.
For that we could easily resurrect my original patch.

Is there anything else which is holding it up?

Cheers,

Hannes

Q: Status of ANA patches

[Christoph Hellwig]

On Fri, Jun 29, 2018@01:42:49PM +0200, Hannes Reinecke wrote:
> Hi Christoph,
>
> do you have any timeline for the ANA patches?
> From my last testing they look good so far; the only missing bit is a 
> missing configfs entry for the actual ANATT value.
> For that we could easily resurrect my original patch.
>
> Is there anything else which is holding it up?

An automated test suite to actually test the code reliably is the
important missing bit.

Q: Status of ANA patches

[Hannes Reinecke]

On 06/29/2018 02:03 PM, Christoph Hellwig wrote:
> On Fri, Jun 29, 2018@01:42:49PM +0200, Hannes Reinecke wrote:
>> Hi Christoph,
>>
>> do you have any timeline for the ANA patches?
>> From my last testing they look good so far; the only missing bit is a 
>> missing configfs entry for the actual ANATT value.
>> For that we could easily resurrect my original patch.
>>
>> Is there anything else which is holding it up?
> 
> An automated test suite to actually test the code reliably is the
> important missing bit.
> 
So, just submitted a blktest to check the basic functionality via
nvme-loop, including path failover.

And send some fixes for issues found during development of the said test :-)

If you can think of anything else which should be tested please let me
know, I'm happy to write up a testcase for that.

But what's next, then?
Will you fold the patches into the main patchset?
Or should they be kept separate?
Should I be doing it (if you are too busy)?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare at suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: F. Imend?rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG N?rnberg)

Q: Status of ANA patches

[Christoph Hellwig]

On Tue, Jul 17, 2018@03:42:06PM +0200, Hannes Reinecke wrote:
> So, just submitted a blktest to check the basic functionality via
> nvme-loop, including path failover.

Thanks!

> And send some fixes for issues found during development of the said test :-)

Yes, that's why we need tests.

> 
> If you can think of anything else which should be tested please let me
> know, I'm happy to write up a testcase for that.
> 
> But what's next, then?
> Will you fold the patches into the main patchset?
> Or should they be kept separate?
> Should I be doing it (if you are too busy)?

Pretty busy this week, so for now just send incremental patches if needed.
I'll try to fold your fixes, try the test suite (and maybe add some
of the bits I did test manually to it) and prepare a merge candidate
for next week.

Q: Status of ANA patches

[Christoph Hellwig]

Btw, another TODO item is nvme-cli support to show the ANA
state of namespaces.

Q: Status of ANA patches

[Chaitanya Kulkarni]

Hi,

I just posted the patch read the ANA log page for name-cli,
maybe we can use that command to show the ANA related
information such as ANA state of the namespace or do we
need to add a new command to nvme-cli? 



From: Linux-nvme <linux-nvme-bounces@lists.infradead.org> on behalf of Christoph Hellwig <hch@lst.de>
Sent: Thursday, July 19, 2018 7:28 AM
To: Hannes Reinecke
Cc: Christoph Hellwig; linux-nvme at lists.infradead.org
Subject: Re: Q: Status of ANA patches
? 
 
Btw, another TODO item is nvme-cli support to show the ANA
state of namespaces.

_______________________________________________
Linux-nvme mailing list
Linux-nvme at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
    

Q: Status of ANA patches

[Christoph Hellwig]

On Wed, Jul 25, 2018@12:50:31AM +0000, Chaitanya Kulkarni wrote:
> Hi,
> 
> I just posted the patch read the ANA log page for name-cli,
> maybe we can use that command to show the ANA related
> information such as ANA state of the namespace or do we
> need to add a new command to nvme-cli? 

We need some way to see the status of namespaces in a given subsystem
(and maybe also per controller).

I think Johannes has done some preliminary work in this area, adding
him to Cc.

Q: Status of ANA patches

[Johannes Thumshirn]

On Wed, Jul 25, 2018@07:05:13AM +0200, Christoph Hellwig wrote:
> We need some way to see the status of namespaces in a given subsystem
> (and maybe also per controller).
> 
> I think Johannes has done some preliminary work in this area, adding
> him to Cc.

I'll have a look at it.

Wanted to give the whole series + Hannes' blktests a shot on my
minimal VMs as well so I think it's a good starting point.

/me hopes to get to it this week

Byte,
	Johannes
-- 
Johannes Thumshirn                                          Storage
jthumshirn at suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850