From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme: Register for ANA AEN
Date: Thu, 26 Jul 2018 14:01:13 +0200 [thread overview]
Message-ID: <20180726120113.GA2289@lst.de> (raw)
In-Reply-To: <20180726115913.GA2187@lst.de>
On Thu, Jul 26, 2018@01:59:13PM +0200, Christoph Hellwig wrote:
> What target do you run against? With the current 4004a TP
> NVME_AEN_CFG_ANA_CHANGE should be set in OAES, which at least the
> Linux target always did anyway.
Ah, but the patches I sent out are missing this host side fix:
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index e482f223f8fd..f6e52ffe6a6d 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1035,7 +1035,7 @@ int nvme_set_queue_count(struct nvme_ctrl *ctrl, int *count)
EXPORT_SYMBOL_GPL(nvme_set_queue_count);
#define NVME_AEN_SUPPORTED \
- (NVME_AEN_CFG_NS_ATTR | NVME_AEN_CFG_FW_ACT)
+ (NVME_AEN_CFG_NS_ATTR | NVME_AEN_CFG_FW_ACT | NVME_AEN_CFG_ANA_CHANGE)
static void nvme_enable_aen(struct nvme_ctrl *ctrl)
{
next prev parent reply other threads:[~2018-07-26 12:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 10:55 [PATCH] nvme: Register for ANA AEN Hannes Reinecke
2018-07-26 10:58 ` Hannes Reinecke
2018-07-26 11:59 ` Christoph Hellwig
2018-07-26 12:01 ` Christoph Hellwig [this message]
2018-07-26 12:02 ` Hannes Reinecke
2018-07-26 12:07 ` Christoph Hellwig
2018-07-26 13:37 ` Hannes Reinecke
2018-07-26 15:12 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180726120113.GA2289@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox