From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH V2] nvmet: use Retain Async Event bit to clear AEN
Date: Fri, 27 Jul 2018 17:14:01 +0200 [thread overview]
Message-ID: <20180727151401.GA30285@lst.de> (raw)
In-Reply-To: <4af8eacd-cddc-9327-0580-fa045ff0170d@suse.de>
On Fri, Jul 27, 2018@03:18:06PM +0200, Hannes Reinecke wrote:
> > u32 len = le16_to_cpu(cmd->get_log_page.numdu);
> > @@ -176,7 +189,7 @@ static void nvmet_execute_get_log_changed_ns(struct nvmet_req *req)
> > if (!status)
> > status = nvmet_zero_sgl(req, len, req->data_len - len);
> > ctrl->nr_changed_ns = 0;
> > - clear_bit(NVME_AEN_CFG_NS_ATTR, &ctrl->aen_masked);
> > + nvmet_clear_aen(req, NVME_AEN_CFG_NS_ATTR);
> > mutex_unlock(&ctrl->lock);
> > out:
> > nvmet_req_complete(req, status);
> >
> Doesn't this apply to the NS CHANGED log page, too?
That code is the changes ns log page..
> IIRC RAE is a generic bit, and not restricted to implementation in
> individual log pages ...
Somewhat generic - only for log pages that have an associated AEN.
The only other one is the ana change log in the ana series. I'll
make sure to cover that as well when merging this patch and the ANA
series.
prev parent reply other threads:[~2018-07-27 15:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 21:00 [PATCH V2] nvmet: use Retain Async Event bit to clear AEN Chaitanya Kulkarni
2018-07-27 13:18 ` Hannes Reinecke
2018-07-27 15:14 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180727151401.GA30285@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).