From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH V2 1/2] nvme-cli: add minimal ana-log page support
Date: Mon, 30 Jul 2018 11:04:45 +0200 [thread overview]
Message-ID: <20180730090445.GA18309@lst.de> (raw)
In-Reply-To: <ef81592a-6c94-aef0-9405-95a5de9ad050@suse.de>
On Mon, Jul 30, 2018@09:43:19AM +0200, Hannes Reinecke wrote:
> This is wrong; 'mnan' is a 32-bit integer.
> (Hence the next field is called 'rsvd544', as it starts at offset 544...)
As a rule of thumb please always add fields in the kernel nvme.h
and then sync it over to nvme-cli.
I guess we need to document that somewhere in nvme-cli..
next prev parent reply other threads:[~2018-07-30 9:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 4:18 [PATCH V2 0/2] nvme-cli: add ana-log support Chaitanya Kulkarni
2018-07-26 4:18 ` [PATCH V2 1/2] nvme-cli: add minimal ana-log page support Chaitanya Kulkarni
2018-07-30 7:43 ` Hannes Reinecke
2018-07-30 9:04 ` Christoph Hellwig [this message]
2018-07-31 17:42 ` Chaitanya Kulkarni
2018-07-26 4:18 ` [PATCH V2 2/2] nvme-cli: add ana-log documentation Chaitanya Kulkarni
2018-07-30 7:43 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180730090445.GA18309@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).