From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH V2 1/3] nvme: add support for ns write protect definitions
Date: Mon, 30 Jul 2018 08:54:26 -0700 [thread overview]
Message-ID: <20180730155426.GA29445@infradead.org> (raw)
In-Reply-To: <20180727025656.9334-2-chaitanya.kulkarni@wdc.com>
On Thu, Jul 26, 2018@07:56:54PM -0700, Chaitanya Kulkarni wrote:
> Add various definitions from NVMe 1.3 TP 4005.
>
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>
> ---
> include/linux/nvme.h | 17 +++++++++++++++--
> 1 file changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/nvme.h b/include/linux/nvme.h
> index 80dfedcf0bf7..8514d4e0b597 100644
> --- a/include/linux/nvme.h
> +++ b/include/linux/nvme.h
> @@ -254,7 +254,7 @@ struct nvme_id_ctrl {
> __le16 awun;
> __le16 awupf;
> __u8 nvscc;
> - __u8 rsvd531;
> + __u8 nwpc;
> __le16 acwu;
> __u8 rsvd534[2];
> __le32 sgls;
> @@ -312,7 +312,9 @@ struct nvme_id_ns {
> __le16 nabspf;
> __le16 noiob;
> __u8 nvmcap[16];
> - __u8 rsvd64[40];
> + __u8 rsvd64[32];
> + __u8 nsattr;
> + __u8 rsvd100[4];
how does this add up? We remove 8 bytes from rsvd64, but
only add 1 in nsattr and 4 in rsvd100?
next prev parent reply other threads:[~2018-07-30 15:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 2:56 [PATCH V2 0/3] nvmet: add support for ns write protect Chaitanya Kulkarni
2018-07-27 2:56 ` [PATCH V2 1/3] nvme: add support for ns write protect definitions Chaitanya Kulkarni
2018-07-30 15:54 ` Christoph Hellwig [this message]
2018-08-01 3:20 ` Chaitanya Kulkarni
2018-07-27 2:56 ` [PATCH V2 2/3] nvme-core: set gendisk read only based on nsattr Chaitanya Kulkarni
2018-07-30 15:54 ` Christoph Hellwig
2018-07-27 2:56 ` [PATCH V2 3/3] nvmet: add ns write protect support Chaitanya Kulkarni
2018-07-30 16:12 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180730155426.GA29445@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).