From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme: fixup crash on failed discovery
Date: Tue, 7 Aug 2018 14:47:44 +0200 [thread overview]
Message-ID: <20180807124744.GA10051@lst.de> (raw)
In-Reply-To: <f85b69d4-c72c-9c04-6a66-80e4acbb58dd@suse.com>
On Tue, Aug 07, 2018@02:01:09PM +0200, Hannes Reinecke wrote:
> On 08/07/2018 01:46 PM, Christoph Hellwig wrote:
> > On Tue, Aug 07, 2018@12:43:42PM +0200, Hannes Reinecke wrote:
> >> When the initial discovery fails the subsystem hasn't been setup,
> >> and we'll encounter a kernel oops during shutdown.
> >
> > This looks ok, but I'm curious where we even call nvme_ctrl_use_ana
> > if we fail early.
> >
> This is called via
> nvme_sysfs_delete()->nvme_ctrl_delete()->nvme_stop_ctrl()->nvme_mpath_stop()
> called from 'nvme discover' on a failing controller.
Thanks. Applied with a slightly updated changelog.
prev parent reply other threads:[~2018-08-07 12:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 10:43 [PATCH] nvme: fixup crash on failed discovery Hannes Reinecke
2018-08-07 11:46 ` Christoph Hellwig
2018-08-07 12:01 ` Hannes Reinecke
2018-08-07 12:47 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180807124744.GA10051@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox