public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: keith.busch@linux.intel.com (Keith Busch)
Subject: [PATCH 2/6] nvme-vendor: fixup c99 declaration in huawei plugin
Date: Fri, 17 Aug 2018 15:56:05 -0600	[thread overview]
Message-ID: <20180817215605.GB9931@localhost.localdomain> (raw)
In-Reply-To: <20180817080956.GB13230@lst.de>

On Fri, Aug 17, 2018@10:09:56AM +0200, Christoph Hellwig wrote:
> On Fri, Aug 17, 2018@09:29:04AM +0200, Hannes Reinecke wrote:
> > We can't use c99 declaration with older compilers.
> > 
> > Signed-off-by: Hannes Reinecke <hare at suse.com>
> 
> Not that I particularly like this feature, but do we really support
> that old compilers?

I don't think those old ones are supported, but I dislike mixed
declarations as well.

  reply	other threads:[~2018-08-17 21:56 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-17  7:29 [PATCH 0/6] nvme-cli fixes and ANA updates Hannes Reinecke
2018-08-17  7:29 ` [PATCH 1/6] nvme-ana-log: fixup compiler warning in show_ana_log() Hannes Reinecke
2018-08-17  8:09   ` Christoph Hellwig
2018-08-17 21:44     ` Chaitanya Kulkarni
2018-08-17 21:55       ` Keith Busch
2018-08-17  7:29 ` [PATCH 2/6] nvme-vendor: fixup c99 declaration in huawei plugin Hannes Reinecke
2018-08-17  8:09   ` Christoph Hellwig
2018-08-17 21:56     ` Keith Busch [this message]
2018-08-17  7:29 ` [PATCH 3/6] nvme-discover: sanitize options Hannes Reinecke
2018-08-17  8:10   ` Christoph Hellwig
2018-08-17  7:29 ` [PATCH 4/6] nvme-discover: Retry discovery log if the generation counter changes Hannes Reinecke
2018-08-17  8:11   ` Christoph Hellwig
2018-08-17 10:06     ` Hannes Reinecke
2018-08-17  7:29 ` [PATCH 5/6] nvme-list-subsys: Print PCIe controller address Hannes Reinecke
2018-08-17  8:12   ` Christoph Hellwig
2018-08-17 10:06     ` Hannes Reinecke
2018-08-17  7:29 ` [PATCH 6/6] nvme-list-subsys: Add device name argument and print out ANA state Hannes Reinecke
2018-08-17  8:12   ` Christoph Hellwig
2018-08-17 22:14   ` Chaitanya Kulkarni
2018-08-17 21:58 ` [PATCH 0/6] nvme-cli fixes and ANA updates Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180817215605.GB9931@localhost.localdomain \
    --to=keith.busch@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox