linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: ming.lei@redhat.com (Ming Lei)
Subject: [PATCH v2] block: fix rdma queue mapping
Date: Tue, 21 Aug 2018 10:04:35 +0800	[thread overview]
Message-ID: <20180821020434.GA24247@ming.t460p> (raw)
In-Reply-To: <20180820205420.25908-1-sagi@grimberg.me>

On Mon, Aug 20, 2018@01:54:20PM -0700, Sagi Grimberg wrote:
> nvme-rdma attempts to map queues based on irq vector affinity.
> However, for some devices, completion vector irq affinity is
> configurable by the user which can break the existing assumption
> that irq vectors are optimally arranged over the host cpu cores.
> 
> So we map queues in two stages:
> First map queues according to corresponding to the completion
> vector IRQ affinity taking the first cpu in the vector affinity map.
> if the current irq affinity is arranged such that a vector is not
> assigned to any distinct cpu, we map it to a cpu that is on the same
> node. If numa affinity can not be sufficed, we map it to any unmapped
> cpu we can find. Then, map the remaining cpus in the possible cpumap
> naively.

I guess this way still can't fix the request allocation crash issue
triggered by using blk_mq_alloc_request_hctx(), in which one hw queue may
not be mapped from any online CPU.

Maybe this patch isn't for this issue, but it is closely related.

Thanks,
Ming

  reply	other threads:[~2018-08-21  2:04 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-20 20:54 [PATCH v2] block: fix rdma queue mapping Sagi Grimberg
2018-08-21  2:04 ` Ming Lei [this message]
2018-08-25  2:06   ` Sagi Grimberg
2018-08-25 12:18     ` Steve Wise
2018-08-27  3:50       ` Ming Lei
2018-08-22 13:11 ` Christoph Hellwig
2018-08-25  2:17   ` Sagi Grimberg
2018-10-03 19:05     ` Steve Wise
2018-10-03 21:14       ` Sagi Grimberg
2018-10-03 21:21         ` Steve Wise
2018-10-16  1:04         ` Sagi Grimberg
2018-10-17 16:37           ` Christoph Hellwig
2018-10-17 16:37       ` Christoph Hellwig
2018-10-23  6:02         ` Sagi Grimberg
2018-10-23 13:00           ` Steve Wise
2018-10-23 21:25             ` Sagi Grimberg
2018-10-23 21:31               ` Steve Wise
2018-10-24  0:09               ` Shiraz Saleem
2018-10-24  0:37                 ` Sagi Grimberg
2018-10-29 23:58                   ` Saleem, Shiraz
2018-10-30 18:26                     ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180821020434.GA24247@ming.t460p \
    --to=ming.lei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).