* [PATCH] nvmet: remove unreachable code
@ 2018-08-23 2:58 Chaitanya Kulkarni
2018-10-09 16:50 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Chaitanya Kulkarni @ 2018-08-23 2:58 UTC (permalink / raw)
Get rid of the unreachable code in the nvmet_parse_discovery_cmd().
Keep the error message identical to the admin-cmd.c and io-cmd*.c
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>
---
drivers/nvme/target/discovery.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/nvme/target/discovery.c b/drivers/nvme/target/discovery.c
index eae29f493a07..d1954f4ca28d 100644
--- a/drivers/nvme/target/discovery.c
+++ b/drivers/nvme/target/discovery.c
@@ -219,12 +219,10 @@ u16 nvmet_parse_discovery_cmd(struct nvmet_req *req)
return NVME_SC_INVALID_OPCODE | NVME_SC_DNR;
}
default:
- pr_err("unsupported cmd %d\n", cmd->common.opcode);
+ pr_err("unhandled cmd %d\n", cmd->common.opcode);
return NVME_SC_INVALID_OPCODE | NVME_SC_DNR;
}
- pr_err("unhandled cmd %d\n", cmd->common.opcode);
- return NVME_SC_INVALID_OPCODE | NVME_SC_DNR;
}
int __init nvmet_init_discovery(void)
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] nvmet: remove unreachable code
2018-08-23 2:58 [PATCH] nvmet: remove unreachable code Chaitanya Kulkarni
@ 2018-10-09 16:50 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2018-10-09 16:50 UTC (permalink / raw)
On Wed, Aug 22, 2018@07:58:45PM -0700, Chaitanya Kulkarni wrote:
> Get rid of the unreachable code in the nvmet_parse_discovery_cmd().
> Keep the error message identical to the admin-cmd.c and io-cmd*.c
>
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>
Thanks,
applied to nvme-4.20.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-09 16:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-23 2:58 [PATCH] nvmet: remove unreachable code Chaitanya Kulkarni
2018-10-09 16:50 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).