linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH nvme-cli 2/4] fabrics: don't fail empty discovery log page
Date: Fri, 31 Aug 2018 18:36:03 -0700	[thread overview]
Message-ID: <20180901013605.10658-3-sagi@grimberg.me> (raw)
In-Reply-To: <20180901013605.10658-1-sagi@grimberg.me>

It can be possible that discovery subsystem will not return
any valid discovery records.

Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
---
 fabrics.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fabrics.c b/fabrics.c
index 28a3e3d9ac82..09cb97c5b880 100644
--- a/fabrics.c
+++ b/fabrics.c
@@ -762,7 +762,8 @@ static int do_discover(char *argstr, bool connect)
 		fprintf(stderr, "Get discovery log entries failed.\n");
 		break;
 	case DISC_NO_LOG:
-		fprintf(stderr, "No discovery log entries to fetch.\n");
+		fprintf(stdout, "No discovery log entries to fetch.\n");
+		ret = DISC_OK;
 		break;
 	case DISC_NOT_EQUAL:
 		fprintf(stderr,
-- 
2.17.1

  parent reply	other threads:[~2018-09-01  1:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-01  1:36 [PATCH nvme-cli 0/4] Some useful fabrics patches Sagi Grimberg
2018-09-01  1:36 ` [PATCH nvme-cli 1/4] fabrics: make some arguments integers Sagi Grimberg
2018-09-01 20:39   ` Chaitanya Kulkarni
2018-09-01  1:36 ` Sagi Grimberg [this message]
2018-09-01 20:40   ` [PATCH nvme-cli 2/4] fabrics: don't fail empty discovery log page Chaitanya Kulkarni
2018-09-01  1:36 ` [PATCH nvme-cli 3/4] nvme: commonize subsystems info in a helper Sagi Grimberg
2018-09-01 20:40   ` Chaitanya Kulkarni
2018-09-01  1:36 ` [PATCH nvme-cli 4/4] fabrics: add disconnect-all command Sagi Grimberg
2018-09-01 20:40   ` Chaitanya Kulkarni
2018-09-06  0:20 ` [PATCH nvme-cli 0/4] Some useful fabrics patches Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180901013605.10658-3-sagi@grimberg.me \
    --to=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).