From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 2/5] nvme: register ns_id attributes as default sysfs groups
Date: Wed, 5 Sep 2018 15:18:21 +0200 [thread overview]
Message-ID: <20180905131821.GA26956@lst.de> (raw)
In-Reply-To: <20180905070053.26239-3-hare@suse.de>
On Wed, Sep 05, 2018@09:00:50AM +0200, Hannes Reinecke wrote:
> We should be registering the ns_id attribute as default sysfs
> attribute groups, otherwise we have a race condition between
> the uevent and the attributes appearing in sysfs.
Please give Bart credit for his work, as the lightnvm bits are almost
bigger than the rest.
> +static umode_t nvm_dev_attrs_visible(struct kobject *kobj,
> + struct attribute *attr, int index)
> {
> + struct device *dev = container_of(kobj, struct device, kobj);
> + struct gendisk *disk = dev_to_disk(dev);
> + struct nvme_ns *ns = disk->private_data;
> struct nvm_dev *ndev = ns->ndev;
> + struct device_attribute *dev_attr =
> + container_of(attr, typeof(*dev_attr), attr);
>
> + if (dev_attr->show == nvm_dev_attr_show)
> + return attr->mode;
>
> + switch (ndev ? ndev->geo.major_ver_id : 0) {
How could ndev be zero here?
next prev parent reply other threads:[~2018-09-05 13:18 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 7:00 [PATCHv3 0/5] genhd: register default groups with device_add_disk() Hannes Reinecke
2018-09-05 7:00 ` [PATCH 1/5] block: genhd: add 'groups' argument to device_add_disk Hannes Reinecke
2018-09-05 15:24 ` Bart Van Assche
2018-09-05 7:00 ` [PATCH 2/5] nvme: register ns_id attributes as default sysfs groups Hannes Reinecke
2018-09-05 13:18 ` Christoph Hellwig [this message]
2018-09-05 13:32 ` Hannes Reinecke
2018-09-05 13:45 ` Christoph Hellwig
2018-09-06 9:56 ` Hannes Reinecke
2018-09-05 7:00 ` [PATCH 3/5] aoe: use device_add_disk_with_groups() Hannes Reinecke
2018-09-05 7:00 ` [PATCH 4/5] zram: register default groups with device_add_disk() Hannes Reinecke
2018-09-05 7:00 ` [PATCH 5/5] virtio-blk: modernize sysfs attribute creation Hannes Reinecke
2018-09-21 5:48 ` [PATCHv3 0/5] genhd: register default groups with device_add_disk() Christoph Hellwig
2018-09-27 19:02 ` Bart Van Assche
-- strict thread matches above, loose matches on Subject: below --
2018-09-28 6:17 [PATCHv4 " Hannes Reinecke
2018-09-28 6:17 ` [PATCH 2/5] nvme: register ns_id attributes as default sysfs groups Hannes Reinecke
2018-09-28 14:15 ` Keith Busch
2018-09-28 15:17 ` Christoph Hellwig
2018-08-14 7:33 [PATCHv2 0/5] genhd: register default groups with device_add_disk() Hannes Reinecke
2018-08-14 7:33 ` [PATCH 2/5] nvme: register ns_id attributes as default sysfs groups Hannes Reinecke
2018-08-14 9:03 ` Javier González
2018-08-14 9:59 ` Matias Bjørling
2018-08-14 15:20 ` Bart Van Assche
2018-08-14 15:39 ` Hannes Reinecke
2018-08-14 15:44 ` Bart Van Assche
2018-08-17 7:00 ` hch
2018-08-17 7:53 ` Hannes Reinecke
2018-08-17 20:04 ` Bart Van Assche
2018-08-17 22:47 ` Sagi Grimberg
2018-08-20 6:34 ` Hannes Reinecke
2018-08-14 21:53 ` kbuild test robot
2018-08-17 6:55 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180905131821.GA26956@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).