From: hch@infradead.org (Christoph Hellwig)
Subject: [REPOST][PATCH] nvme_fc: add 'nvme_discovery' sysfs attribute to fc transport device
Date: Mon, 17 Sep 2018 06:41:27 -0700 [thread overview]
Message-ID: <20180917134127.GA6009@infradead.org> (raw)
In-Reply-To: <c806be1b-f86f-de84-3669-d9bb89aaaf65@gmail.com>
On Tue, Sep 11, 2018@11:02:13AM -0700, James Smart wrote:
> Well, I don't think I agree with you on the safeness of the locking, but
> moving it to the other style isn't different and looks more normal. I'll
> rework it.
You are iterating the list without the lock and only take the lock
to remove the entry - this is racy vs another thread adding to or
removing from the list.
next prev parent reply other threads:[~2018-09-17 13:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-20 22:06 [REPOST][PATCH] nvme_fc: add 'nvme_discovery' sysfs attribute to fc transport device James Smart
2018-09-05 20:14 ` James Smart
2018-09-11 8:58 ` Christoph Hellwig
2018-09-11 18:02 ` James Smart
2018-09-17 13:41 ` Christoph Hellwig [this message]
2018-09-17 16:07 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180917134127.GA6009@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).