From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme/pci: Fix hot removal during error handling
Date: Thu, 20 Sep 2018 08:30:47 +0200 [thread overview]
Message-ID: <20180920063047.GA12913@lst.de> (raw)
In-Reply-To: <20180919154852.28187-1-keith.busch@intel.com>
On Wed, Sep 19, 2018@09:48:52AM -0600, Keith Busch wrote:
> A removal waits for the reset_work to complete. If a surprise removal
> occurs around the same time as an error triggered controller reset,
> and reset work happened to dispatch a command to the removed controller,
> the command won't be recovered since the timeout work doesn't do
> anything during error recovery.
>
> This patch fixes this by killing admin queues prior to syncing reset.
>
> Signed-off-by: Keith Busch <keith.busch at intel.com>
Looks sensible to me:
Reviewed-by: Christoph Hellwig <hch at lst.de>
prev parent reply other threads:[~2018-09-20 6:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 15:48 [PATCH] nvme/pci: Fix hot removal during error handling Keith Busch
2018-09-20 6:30 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180920063047.GA12913@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).