From: hch@lst.de (Christoph Hellwig)
Subject: [PATCHv3 0/5] genhd: register default groups with device_add_disk()
Date: Fri, 21 Sep 2018 07:48:43 +0200 [thread overview]
Message-ID: <20180921054843.GA13157@lst.de> (raw)
In-Reply-To: <20180905070053.26239-1-hare@suse.de>
Can you resend this with the one easy fixup pointed out? It would
be good to finally get the race fix merged.
On Wed, Sep 05, 2018@09:00:48AM +0200, Hannes Reinecke wrote:
> device_add_disk() doesn't allow to register with default sysfs groups,
> which introduces a race with udev as these groups have to be created after
> the uevent has been sent.
> This patchset updates device_add_disk() to accept a 'groups' argument to
> avoid this race and updates the obvious drivers to use it.
> There are some more drivers which might benefit from this (eg loop or md),
> but the interface is not straightforward so I haven't attempted it.
>
> As usual, comments and reviews are welcome.
>
> Changes to v2:
> - Fold lightnvm attributes into the generic attribute group as
> suggested by Bart
>
> Changes to v1:
> - Drop first patch
> - Convert lightnvm sysfs attributes as suggested by Bart
>
> Hannes Reinecke (5):
> block: genhd: add 'groups' argument to device_add_disk
> nvme: register ns_id attributes as default sysfs groups
> aoe: use device_add_disk_with_groups()
> zram: register default groups with device_add_disk()
> virtio-blk: modernize sysfs attribute creation
>
> arch/um/drivers/ubd_kern.c | 2 +-
> block/genhd.c | 19 +++++--
> drivers/block/aoe/aoe.h | 1 -
> drivers/block/aoe/aoeblk.c | 21 +++----
> drivers/block/aoe/aoedev.c | 1 -
> drivers/block/floppy.c | 2 +-
> drivers/block/mtip32xx/mtip32xx.c | 2 +-
> drivers/block/ps3disk.c | 2 +-
> drivers/block/ps3vram.c | 2 +-
> drivers/block/rsxx/dev.c | 2 +-
> drivers/block/skd_main.c | 2 +-
> drivers/block/sunvdc.c | 2 +-
> drivers/block/virtio_blk.c | 68 +++++++++++++----------
> drivers/block/xen-blkfront.c | 2 +-
> drivers/block/zram/zram_drv.c | 28 +++-------
> drivers/ide/ide-cd.c | 2 +-
> drivers/ide/ide-gd.c | 2 +-
> drivers/memstick/core/ms_block.c | 2 +-
> drivers/memstick/core/mspro_block.c | 2 +-
> drivers/mmc/core/block.c | 2 +-
> drivers/mtd/mtd_blkdevs.c | 2 +-
> drivers/nvdimm/blk.c | 2 +-
> drivers/nvdimm/btt.c | 2 +-
> drivers/nvdimm/pmem.c | 2 +-
> drivers/nvme/host/core.c | 21 +++----
> drivers/nvme/host/lightnvm.c | 106 +++++++++++++++---------------------
> drivers/nvme/host/multipath.c | 15 ++---
> drivers/nvme/host/nvme.h | 10 +---
> drivers/s390/block/dasd_genhd.c | 2 +-
> drivers/s390/block/dcssblk.c | 2 +-
> drivers/s390/block/scm_blk.c | 2 +-
> drivers/scsi/sd.c | 2 +-
> drivers/scsi/sr.c | 2 +-
> include/linux/genhd.h | 5 +-
> 34 files changed, 151 insertions(+), 190 deletions(-)
>
> --
> 2.16.4
---end quoted text---
next prev parent reply other threads:[~2018-09-21 5:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 7:00 [PATCHv3 0/5] genhd: register default groups with device_add_disk() Hannes Reinecke
2018-09-05 7:00 ` [PATCH 1/5] block: genhd: add 'groups' argument to device_add_disk Hannes Reinecke
2018-09-05 15:24 ` Bart Van Assche
2018-09-05 7:00 ` [PATCH 2/5] nvme: register ns_id attributes as default sysfs groups Hannes Reinecke
2018-09-05 13:18 ` Christoph Hellwig
2018-09-05 13:32 ` Hannes Reinecke
2018-09-05 13:45 ` Christoph Hellwig
2018-09-06 9:56 ` Hannes Reinecke
2018-09-05 7:00 ` [PATCH 3/5] aoe: use device_add_disk_with_groups() Hannes Reinecke
2018-09-05 7:00 ` [PATCH 4/5] zram: register default groups with device_add_disk() Hannes Reinecke
2018-09-05 7:00 ` [PATCH 5/5] virtio-blk: modernize sysfs attribute creation Hannes Reinecke
2018-09-21 5:48 ` Christoph Hellwig [this message]
2018-09-27 19:02 ` [PATCHv3 0/5] genhd: register default groups with device_add_disk() Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180921054843.GA13157@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).