linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH 5/4 nvme-cli] fabrics: support fabrics sq flow control disable
Date: Wed,  3 Oct 2018 01:13:23 -0700	[thread overview]
Message-ID: <20181003081323.7504-6-sagi@grimberg.me> (raw)
In-Reply-To: <20181003081323.7504-1-sagi@grimberg.me>

If the discovery log entry indicates that the subsystem
supports disabling sq flow control, we ask the host to
connect and disable sq flow control (omit sq_head pointer
updates).

Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
---
 fabrics.c    | 9 +++++++++
 linux/nvme.h | 7 ++++---
 2 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/fabrics.c b/fabrics.c
index d937df47b68e..2db651645f52 100644
--- a/fabrics.c
+++ b/fabrics.c
@@ -132,6 +132,8 @@ static const char * const treqs[] = {
 	[NVMF_TREQ_NOT_SPECIFIED]	= "not specified",
 	[NVMF_TREQ_REQUIRED]		= "required",
 	[NVMF_TREQ_NOT_REQUIRED]	= "not required",
+	[NVMF_TREQ_DISABLE_SQFLOW]	= "not specified, "
+					  "sq flow control disable supported",
 };
 
 static inline const char *treq_str(__u8 treq)
@@ -748,6 +750,13 @@ static int connect_ctrl(struct nvmf_disc_rsp_page_entry *e)
 		return -EINVAL;
 	}
 
+	if (e->treq & NVMF_TREQ_DISABLE_SQFLOW) {
+		len = sprintf(p, ",disable_sqflow");
+		if (len < 0)
+			return -EINVAL;
+		p += len;
+	}
+
 	if (discover)
 		return do_discover(argstr, true);
 	else
diff --git a/linux/nvme.h b/linux/nvme.h
index 37d3bc1ace6a..4f12c94db4d7 100644
--- a/linux/nvme.h
+++ b/linux/nvme.h
@@ -58,9 +58,10 @@ enum {
 
 /* Transport Requirements codes for Discovery Log Page entry TREQ field */
 enum {
-	NVMF_TREQ_NOT_SPECIFIED	= 0,	/* Not specified */
-	NVMF_TREQ_REQUIRED	= 1,	/* Required */
-	NVMF_TREQ_NOT_REQUIRED	= 2,	/* Not Required */
+	NVMF_TREQ_NOT_SPECIFIED	= 0,		/* Not specified */
+	NVMF_TREQ_REQUIRED	= 1,		/* Required */
+	NVMF_TREQ_NOT_REQUIRED	= 2,		/* Not Required */
+	NVMF_TREQ_DISABLE_SQFLOW = (1 << 2),	/* SQ flow control disable supported */
 };
 
 /* RDMA QP Service Type codes for Discovery Log Page entry TSAS
-- 
2.17.1

  parent reply	other threads:[~2018-10-03  8:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-03  8:13 [PATCH v2 0/4] Support SQ flow control disabled mode (TP 8005) Sagi Grimberg
2018-10-03  8:13 ` [PATCH v2 1/4] nvmet: support fabrics sq flow control Sagi Grimberg
2018-11-14 14:19   ` Christoph Hellwig
2018-11-14 16:29     ` Sagi Grimberg
2018-10-03  8:13 ` [PATCH v2 2/4] nvmet: don't override treq upon modification Sagi Grimberg
2018-11-14 14:20   ` Christoph Hellwig
2018-11-14 16:30     ` Sagi Grimberg
2018-10-03  8:13 ` [PATCH v2 3/4] nvmet: expose support for fabrics SQ flow control disable in treq Sagi Grimberg
2018-10-03  8:13 ` [PATCH v2 4/4] nvme: disable fabrics SQ flow control when asked by the user Sagi Grimberg
2018-10-03  8:41   ` Hannes Reinecke
2018-11-14 14:21   ` Christoph Hellwig
2018-11-14 16:32     ` Sagi Grimberg
2018-10-03  8:13 ` Sagi Grimberg [this message]
2018-10-16  1:06 ` [PATCH v2 0/4] Support SQ flow control disabled mode (TP 8005) Sagi Grimberg
2018-10-31  5:03 ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181003081323.7504-6-sagi@grimberg.me \
    --to=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).