linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvmetcli: ANA configuration support
Date: Sat, 6 Oct 2018 14:43:53 +0200	[thread overview]
Message-ID: <20181006124353.GA8324@lst.de> (raw)
In-Reply-To: <20180727110859.4212-1-hare@suse.de>

I just wanted to apply this in preparation of a new nvmetcli release
once Linux 4.19 is released with ANA support, but the code does not
seem to work well on kernel without multipath support.  E.g.:

Traceback (most recent call last):
  File "./nvmetcli", line 735, in <module>
    main()
  File "./nvmetcli", line 717, in main
    funcs[sys.argv[1]](savefile)
  File "./nvmetcli", line 684, in clear
    nvme.Root().clear_existing()
  File "/root/nvmetcli/nvmet/nvme.py", line 315, in clear_existing
    p.delete()
  File "/root/nvmetcli/nvmet/nvme.py", line 676, in delete
    a.delete()
  File "/root/nvmetcli/nvmet/nvme.py", line 200, in delete
    os.rmdir(self.path)
PermissionError: [Errno 1] Operation not permitted: '/sys/kernel/config/nvmet/ports/2/ana_groups/1'

The new ANA code will probably need similar exception handling as the
inline_data_size attribute.

  reply	other threads:[~2018-10-06 12:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-27 11:08 [PATCH] nvmetcli: ANA configuration support Hannes Reinecke
2018-10-06 12:43 ` Christoph Hellwig [this message]
2018-10-06 13:09   ` Hannes Reinecke
2018-10-17  7:11     ` Christoph Hellwig
2018-11-08  8:48       ` Christoph Hellwig
2018-11-08  8:59         ` Hannes Reinecke
  -- strict thread matches above, loose matches on Subject: below --
2018-06-07  9:57 [PATCH nvmetcli] " Hannes Reinecke
2018-06-07 10:00 ` Johannes Thumshirn
2018-06-07 12:12   ` Christoph Hellwig
2018-06-07 12:38     ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181006124353.GA8324@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).