From: keith.busch@linux.intel.com (Keith Busch)
Subject: [PATCH] nvme-pci: remove duplicate check
Date: Wed, 17 Oct 2018 13:14:14 -0600 [thread overview]
Message-ID: <20181017191414.GB20375@localhost.localdomain> (raw)
In-Reply-To: <20181017183415.3373-1-chaitanya.kulkarni@wdc.com>
On Wed, Oct 17, 2018@11:34:15AM -0700, Chaitanya Kulkarni wrote:
> This is a cleanup patch doesn't change any functionality. It removes
> the duplicate call to the blk_integrity_rq() in the nvme_map_data().
>
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>
Looks good.
Reviewed-by: Keith Busch <keith.busch at intel.com>
> ---
> drivers/nvme/host/pci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 72737009b82d..4e023cd007e1 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -772,10 +772,10 @@ static blk_status_t nvme_map_data(struct nvme_dev *dev, struct request *req,
>
> if (!dma_map_sg(dev->dev, &iod->meta_sg, 1, dma_dir))
> goto out_unmap;
> - }
>
> - if (blk_integrity_rq(req))
> cmnd->rw.metadata = cpu_to_le64(sg_dma_address(&iod->meta_sg));
> + }
> +
> return BLK_STS_OK;
>
> out_unmap:
> --
next prev parent reply other threads:[~2018-10-17 19:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 18:34 [PATCH] nvme-pci: remove duplicate check Chaitanya Kulkarni
2018-10-17 19:14 ` Keith Busch [this message]
2018-10-18 7:31 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181017191414.GB20375@localhost.localdomain \
--to=keith.busch@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox