Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] nvmet: adjust the serial number format function
Date: Thu, 25 Oct 2018 09:14:13 -0600	[thread overview]
Message-ID: <20181025151413.GC5138@localhost.localdomain> (raw)
In-Reply-To: <1540201713-14848-1-git-send-email-lijie34@huawei.com>

On Mon, Oct 22, 2018@05:48:33PM +0800, lijie wrote:
> The serial number displayed on the host side using the nvme list command
> is different from the attr_serial at the target side, because the
> nvmet_execute_identify_ctrl function and the
> nvmet_subsys_attr_serial_store function use different types of formatting
> functions.

I think the more fundamental reason for the display difference is one
of these is a u8[] and the other a u64, and it makes more sense to me
if both were u8[].

  reply	other threads:[~2018-10-25 15:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-22  9:48 [PATCH] nvmet: adjust the serial number format function lijie
2018-10-25 15:14 ` Keith Busch [this message]
2018-10-26  1:38   ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181025151413.GC5138@localhost.localdomain \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox