From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] nvme-pci: Add Write Zero support to Intel 660p
Date: Fri, 26 Oct 2018 16:58:07 -0600 [thread overview]
Message-ID: <20181026225807.GA10621@localhost.localdomain> (raw)
In-Reply-To: <20181026224146.198311-1-gwendal@chromium.org>
On Fri, Oct 26, 2018@03:41:46PM -0700, Gwendal Grignou wrote:
> Given Intel 660p returns 0 when reading discarded data,
> allow Write Zero.
>
> nvme id-ns /dev/nvme0n1
> ...
> dlfeat : 1
> ...
>
> Check Write Zeros is now enabled:
> cat /sys/block/nvme0n1/queue/write_zeroes_max_bytes
> 2199023255040
>
> Signed-off-by: Gwendal Grignou <gwendal at chromium.org>
> ---
> drivers/nvme/host/pci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 7e09e45b0b28d..b81ad51d78b72 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -2694,6 +2694,8 @@ static const struct pci_device_id nvme_id_table[] = {
> { PCI_VDEVICE(INTEL, 0xf1a5), /* Intel 600P/P3100 */
> .driver_data = NVME_QUIRK_NO_DEEPEST_PS |
> NVME_QUIRK_MEDIUM_PRIO_SQ },
> + { PCI_VDEVICE(INTEL, 0xf1a8), /* Intel 660P */
> + .driver_data = NVME_QUIRK_DEALLOCATE_ZEROES, },
The quirk is for devices that pre-date the ability to discover the
capability. Now that we have a spec defined way to know a device's
deallocate behavior, and this particular device implements that method,
we should use that instead of a quirk.
next prev parent reply other threads:[~2018-10-26 22:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 22:41 [PATCH] nvme-pci: Add Write Zero support to Intel 660p Gwendal Grignou
2018-10-26 22:58 ` Keith Busch [this message]
2018-10-27 7:44 ` Christoph Hellwig
2018-10-27 9:19 ` Chaitanya Kulkarni
2018-10-29 15:24 ` Keith Busch
2018-11-01 5:27 ` Christoph Hellwig
2018-11-01 14:38 ` Keith Busch
2018-11-02 6:08 ` Christoph Hellwig
2018-11-02 14:21 ` Keith Busch
2018-11-03 8:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181026225807.GA10621@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).