From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme-pci: Add Write Zero support to Intel 660p
Date: Sat, 27 Oct 2018 09:44:52 +0200 [thread overview]
Message-ID: <20181027074452.GA15404@lst.de> (raw)
In-Reply-To: <20181026225807.GA10621@localhost.localdomain>
On Fri, Oct 26, 2018@04:58:07PM -0600, Keith Busch wrote:
> The quirk is for devices that pre-date the ability to discover the
> capability. Now that we have a spec defined way to know a device's
> deallocate behavior, and this particular device implements that method,
> we should use that instead of a quirk.
The 'Deallocate Logical Block Features' bits 0 and 1 only tell what
is read back from deallocated logic blocks, but it does not guarantee
that all blocks a DSM deallocate is called on are actually deallocated.
That being said I really don't want to add more 'feature hacks' like this,
it is time that we go back to a proper Write Zeroes implementation.
next prev parent reply other threads:[~2018-10-27 7:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 22:41 [PATCH] nvme-pci: Add Write Zero support to Intel 660p Gwendal Grignou
2018-10-26 22:58 ` Keith Busch
2018-10-27 7:44 ` Christoph Hellwig [this message]
2018-10-27 9:19 ` Chaitanya Kulkarni
2018-10-29 15:24 ` Keith Busch
2018-11-01 5:27 ` Christoph Hellwig
2018-11-01 14:38 ` Keith Busch
2018-11-02 6:08 ` Christoph Hellwig
2018-11-02 14:21 ` Keith Busch
2018-11-03 8:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181027074452.GA15404@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).