From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme: make sure ns head inherits underlying device limits
Date: Wed, 31 Oct 2018 06:27:45 +0100 [thread overview]
Message-ID: <20181031052745.GA13521@lst.de> (raw)
In-Reply-To: <4cd69ced-7e16-e5dd-716d-53784e2ed32f@grimberg.me>
On Tue, Oct 30, 2018@11:11:11AM -0700, Sagi Grimberg wrote:
> Christoph,
>
>>> Without this patch at least max_segments and max_hw_sectors of the head
>>> device node are degenerated to defaults that have nothing to do with the
>>> underlying device limits.
>>>
>>> This can result in unnecessary bio splitting for the head device
>>> node...
>>
>> But we never split bios for the multipath queue!
>
> Yes of course we don't, but we can still stack other devices on top
> of the multipath device that can split bios and in fact rely on the
> underlying queue limits.
Ok, that makes sense. Can you resubmit it with that in a comment?
prev parent reply other threads:[~2018-10-31 5:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 22:24 [PATCH] nvme: make sure ns head inherits underlying device limits Sagi Grimberg
2018-10-22 8:57 ` Christoph Hellwig
2018-10-23 0:22 ` Sagi Grimberg
2018-10-26 7:53 ` Christoph Hellwig
2018-10-30 18:11 ` Sagi Grimberg
2018-10-31 5:27 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031052745.GA13521@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).