From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] nvme-pci: Add Write Zero support to Intel 660p
Date: Thu, 1 Nov 2018 08:38:08 -0600 [thread overview]
Message-ID: <20181101143807.GL19483@localhost.localdomain> (raw)
In-Reply-To: <20181101052749.GA4349@lst.de>
On Thu, Nov 01, 2018@06:27:49AM +0100, Christoph Hellwig wrote:
> On Mon, Oct 29, 2018@09:24:01AM -0600, Keith Busch wrote:
> > > The 'Deallocate Logical Block Features' bits 0 and 1 only tell what
> > > is read back from deallocated logic blocks, but it does not guarantee
> > > that all blocks a DSM deallocate is called on are actually deallocated.
> >
> > Sure, but whether the requested blocks are deallocated or not is
> > irrelevant. We're only using this feature here for its deterministic
> > read behavior.
>
> I can't parse this.
We currently use DSM Deallocate for REQ_OP_WRITE_ZEROES. We don't care
if the blocks are actually deallocated. We only care if reading them
back determinisitically returns 0's, and DLFEAT tells us if we can rely
on that behavior. I'm just suggesting to use that instead of using
the NVME_QUIRK_DEALLOCATE_ZEROES quirk.
next prev parent reply other threads:[~2018-11-01 14:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 22:41 [PATCH] nvme-pci: Add Write Zero support to Intel 660p Gwendal Grignou
2018-10-26 22:58 ` Keith Busch
2018-10-27 7:44 ` Christoph Hellwig
2018-10-27 9:19 ` Chaitanya Kulkarni
2018-10-29 15:24 ` Keith Busch
2018-11-01 5:27 ` Christoph Hellwig
2018-11-01 14:38 ` Keith Busch [this message]
2018-11-02 6:08 ` Christoph Hellwig
2018-11-02 14:21 ` Keith Busch
2018-11-03 8:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181101143807.GL19483@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).