From mboxrd@z Thu Jan  1 00:00:00 1970
From: hch@infradead.org (Christoph Hellwig)
Date: Wed, 14 Nov 2018 06:20:32 -0800
Subject: [PATCH v2 2/4] nvmet: don't override treq upon modification.
In-Reply-To: <20181003081323.7504-3-sagi@grimberg.me>
References: <20181003081323.7504-1-sagi@grimberg.me>
 <20181003081323.7504-3-sagi@grimberg.me>
Message-ID: <20181114142032.GB27204@infradead.org>

On Wed, Oct 03, 2018@01:13:20AM -0700, Sagi Grimberg wrote:
> Only override the allowed parts of it.
> 
> Reviewed-by: Hannes Reinecke <hare at suse.com>
> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
> ---
>  drivers/nvme/target/configfs.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c
> index b37a8e3e3f80..53b88858ee97 100644
> --- a/drivers/nvme/target/configfs.c
> +++ b/drivers/nvme/target/configfs.c
> @@ -148,7 +148,7 @@ CONFIGFS_ATTR(nvmet_, addr_traddr);
>  static ssize_t nvmet_addr_treq_show(struct config_item *item,
>  		char *page)
>  {
> -	switch (to_nvmet_port(item)->disc_addr.treq) {
> +	switch (to_nvmet_port(item)->disc_addr.treq & 0x3) {
>  	case NVMF_TREQ_NOT_SPECIFIED:
>  		return sprintf(page, "not specified\n");
>  	case NVMF_TREQ_REQUIRED:
> @@ -164,6 +164,7 @@ static ssize_t nvmet_addr_treq_store(struct config_item *item,
>  		const char *page, size_t count)
>  {
>  	struct nvmet_port *port = to_nvmet_port(item);
> +	u8 treq = port->disc_addr.treq & 0xfc;

I think this wants a named constant instead of a magic value.