Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme: default to 0 poll queues
Date: Mon, 19 Nov 2018 08:57:37 +0100	[thread overview]
Message-ID: <20181119075737.GA10256@lst.de> (raw)
In-Reply-To: <a2d999c8-135a-745f-07c2-e6c2dc52fff1@kernel.dk>

On Sat, Nov 17, 2018@10:06:20AM -0700, Jens Axboe wrote:
> We need a better way of configuring this, and given that
> polling is (still) a bit niche, let's default to using
> 0 poll queues. That way we'll have the same read/write/poll
> behavior as 4.20, and users that want to test/use polling
> are required to do manual configuration of the number of
> poll queues.
> 
> Signed-off-by: Jens Axboe <axboe at kernel.dk>

Looks good (except that you could use more of each line for the
commit log).

Reviewed-by: Christoph Hellwig <hch at lst.de>

Given that the poll queues were introduced in the block tree, can you
queue it up there?

  reply	other threads:[~2018-11-19  7:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-17 17:06 [PATCH] nvme: default to 0 poll queues Jens Axboe
2018-11-19  7:57 ` Christoph Hellwig [this message]
2018-11-19 15:18   ` Jens Axboe
     [not found] <20181209004953.GA11638@roeck-us.net>
2018-12-09  5:38 ` Jens Axboe
2018-12-09  6:22   ` Guenter Roeck
2018-12-09  6:31     ` Jens Axboe
2018-12-09  7:32       ` Guenter Roeck
2018-12-09 18:18       ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181119075737.GA10256@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox