From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 0/2] nvme-multipath: round-robin I/O policy
Date: Tue, 20 Nov 2018 17:19:43 +0100 [thread overview]
Message-ID: <20181120161943.GA2755@lst.de> (raw)
In-Reply-To: <f235714b-6f3c-eba7-4f37-5bef6dab600e@suse.de>
On Tue, Nov 20, 2018@05:02:14PM +0100, Hannes Reinecke wrote:
> Also once we abandon direct NUMA mapping there's no good reason why we
> should be selecting paths based on NUMA node; it might actually be better
> to use the core id here, as then we could map as many paths as we have
> CPUs.
True.
> So in the end the round-robin scheduler was just easier to implement, and
> actually provided better performance on my testbed.
Oh well. I guess we can pick it up as a tribute to FC given that it
isn't all that horrible. I just hate using a dumb scheme like round
robin when we otherwise spend all our time optimizing every last cycle
and cache line. I'll do another detailed review and will consider
picking it up as a non-default choice.
next prev parent reply other threads:[~2018-11-20 16:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 12:29 [PATCH 0/2] nvme-multipath: round-robin I/O policy Hannes Reinecke
2018-11-15 12:29 ` [PATCH 1/2] nvme-multipath: add 'iopolicy' subsystem attribute Hannes Reinecke
2018-11-15 17:35 ` Sagi Grimberg
2018-11-16 8:07 ` Hannes Reinecke
2018-11-15 12:29 ` [PATCH 2/2] nvme-multipath: round-robin I/O policy Hannes Reinecke
2018-11-20 16:42 ` Christoph Hellwig
2018-11-20 20:30 ` Hannes Reinecke
2018-11-21 8:28 ` Christoph Hellwig
2018-11-21 11:24 ` Hannes Reinecke
[not found] ` <8a583536-151e-6f68-f4f9-98d8c4b853dd@broadcom.com>
2018-11-21 11:09 ` Hannes Reinecke
2018-11-22 13:52 ` Hannes Reinecke
2018-11-16 8:26 ` [PATCH 0/2] " Christoph Hellwig
2018-11-20 16:02 ` Hannes Reinecke
2018-11-20 16:19 ` Christoph Hellwig [this message]
2018-12-05 20:05 ` Ewan D. Milne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181120161943.GA2755@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).