From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme: Implement Enhanced Command Retry
Date: Tue, 27 Nov 2018 17:14:26 +0100 [thread overview]
Message-ID: <20181127161426.GA27370@lst.de> (raw)
In-Reply-To: <20181127155000.GA6401@localhost.localdomain>
On Tue, Nov 27, 2018@08:50:00AM -0700, Keith Busch wrote:
> On Tue, Nov 27, 2018@04:46:26PM +0100, Christoph Hellwig wrote:
> > On Tue, Nov 27, 2018@08:37:10AM -0700, Keith Busch wrote:
> > > if (!blk_queue_dying(req->q)) {
> > > + unsigned long delay = 0;
> > > + struct nvme_ns *ns = req->q->queuedata;
> > > + u16 crd = (nvme_req(req)->status & NVME_SC_CRD) >> 11;
> > > +
> > > + if (crd && ns)
> > > + delay = ns->ctrl->crdt[crd - 1] * 100;
> >
> > Do we need bounce checking for crd here?
>
> I assume you mean bounds, in which case it should not be necessary since
> the result of the mask and shift can't be > 3, which is the size of the
> crdt array. I can add the check if not having it is visually alarming.
True, I don't think we'll need a check. Maybe at best a comment.
prev parent reply other threads:[~2018-11-27 16:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 15:37 [PATCH] nvme: Implement Enhanced Command Retry Keith Busch
2018-11-27 15:46 ` Christoph Hellwig
2018-11-27 15:50 ` Keith Busch
2018-11-27 16:14 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127161426.GA27370@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox