From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme: fix irq vs io_queue calculations
Date: Tue, 11 Dec 2018 08:08:55 +0100 [thread overview]
Message-ID: <20181211070855.GA13999@lst.de> (raw)
In-Reply-To: <0d463400-f954-7588-1ae9-2c68e52e9082@kernel.dk>
> + if (!(result < 0 || irq_queues == 1))
> + irq_queues = irq_sets[0] + irq_sets[1] + 1;
Maybe its just me, but I hate this style of conditions, why not:
if (result >= 0 && irq_queues > 1)
irq_queues = irq_sets[0] + irq_sets[1] + 1;
Otherwise this looks fine to me:
Reviewed-by: Christoph Hellwig <hch at lst.de>
next prev parent reply other threads:[~2018-12-11 7:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-09 18:21 [PATCH] nvme: fix irq vs io_queue calculations Jens Axboe
2018-12-09 20:32 ` Guenter Roeck
2018-12-11 7:08 ` Christoph Hellwig [this message]
2018-12-11 13:24 ` Jens Axboe
2018-12-11 10:50 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181211070855.GA13999@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox