From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH v2 4/5] nvme-tcp: support separate queue maps for read and write
Date: Wed, 12 Dec 2018 08:05:10 +0100 [thread overview]
Message-ID: <20181212070510.GA28461@lst.de> (raw)
In-Reply-To: <20181211233519.9350-5-sagi@grimberg.me>
> - queue->io_cpu = (qid == 0) ? 0 : qid - 1;
> + n = (qid ? qid - 1 : 0) % num_online_cpus();
> + queue->io_cpu = cpumask_next_wrap(n - 1, cpu_online_mask, -1, false);
Nitpick: can you use an if/else here? The ? : construct just looks
like obsfucation.
If nothing else pops up I can fix that up when applying.
Otherwise:
Reviewed-by: Christoph Hellwig <hch at lst.de>
next prev parent reply other threads:[~2018-12-12 7:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 23:35 [PATCH v2 0/5] implement nvmf read/write queue maps Sagi Grimberg
2018-12-11 23:35 ` [PATCH v2 1/5] blk-mq-rdma: pass in queue map to blk_mq_rdma_map_queues Sagi Grimberg
2018-12-11 23:35 ` [PATCH v2 2/5] nvme-fabrics: add missing nvmf_ctrl_options documentation Sagi Grimberg
2018-12-11 23:35 ` [PATCH v2 3/5] nvme-fabrics: allow user to set nr_write_queues for separate queue maps Sagi Grimberg
2018-12-11 23:35 ` [PATCH v2 4/5] nvme-tcp: support separate queue maps for read and write Sagi Grimberg
2018-12-12 7:05 ` Christoph Hellwig [this message]
2018-12-12 7:10 ` Sagi Grimberg
2018-12-11 23:35 ` [PATCH v2 5/5] nvme-rdma: " Sagi Grimberg
2018-12-12 7:05 ` Christoph Hellwig
2018-12-11 23:35 ` [PATCH v2 nvme-cli 6/5] fabrics: pass in number of write queues Sagi Grimberg
2018-12-12 17:23 ` [PATCH v2 0/5] implement nvmf read/write queue maps James Smart
2018-12-12 17:58 ` Sagi Grimberg
2018-12-12 19:15 ` James Smart
2018-12-13 12:04 ` Hannes Reinecke
2018-12-13 14:02 ` Jens Axboe
2018-12-13 14:19 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212070510.GA28461@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox