From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH V2 04/12] nvmet: add interface to update error-log page
Date: Thu, 13 Dec 2018 09:52:43 +0100 [thread overview]
Message-ID: <20181213085243.GA1611@lst.de> (raw)
In-Reply-To: <20181212231148.4107-5-chaitanya.kulkarni@wdc.com>
This needed a little byte swapping fix:
diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c
index ba0ab5481cc5..cc81d0231587 100644
--- a/drivers/nvme/target/core.c
+++ b/drivers/nvme/target/core.c
@@ -677,7 +677,7 @@ static void nvmet_set_error(struct nvmet_req *req, u16 status)
new_error_slot->status_field = cpu_to_le16(status << 1);
new_error_slot->param_error_location = cpu_to_le16(req->error_loc);
new_error_slot->lba = cpu_to_le64(req->error_slba);
- new_error_slot->nsid = cpu_to_le32(req->cmd->common.nsid);
+ new_error_slot->nsid = req->cmd->common.nsid;
spin_unlock_irqrestore(&ctrl->error_lock, flags);
/* set the more bit for this request */
next prev parent reply other threads:[~2018-12-13 8:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 23:11 [PATCH V2 00/12] nvmet: add error log page support Chaitanya Kulkarni
2018-12-12 23:11 ` [PATCH V2 01/12] nvme: remove nvme_common command cdw10 array Chaitanya Kulkarni
2018-12-13 8:53 ` Christoph Hellwig
2018-12-12 23:11 ` [PATCH V2 02/12] nvme: add error log page slot definition Chaitanya Kulkarni
2018-12-12 23:11 ` [PATCH V2 03/12] nvmet: add error-log definitions Chaitanya Kulkarni
2018-12-12 23:11 ` [PATCH V2 04/12] nvmet: add interface to update error-log page Chaitanya Kulkarni
2018-12-13 8:52 ` Christoph Hellwig [this message]
2018-12-12 23:11 ` [PATCH V2 05/12] nvmet: add error log support in the core Chaitanya Kulkarni
2018-12-12 23:11 ` [PATCH V2 06/12] nvmet: add error log support for bdev backend Chaitanya Kulkarni
2018-12-13 2:52 ` Sagi Grimberg
2018-12-12 23:11 ` [PATCH V2 07/12] nvmet: add error log support for file backend Chaitanya Kulkarni
2018-12-13 2:51 ` Sagi Grimberg
2018-12-12 23:11 ` [PATCH V2 08/12] nvmet: add error log support for fabrics-cmd Chaitanya Kulkarni
2018-12-12 23:11 ` [PATCH V2 09/12] nvmet: add error log support for rdma backend Chaitanya Kulkarni
2018-12-12 23:11 ` [PATCH V2 10/12] nvmet: add error log support for admin-cmd Chaitanya Kulkarni
2018-12-12 23:11 ` [PATCH V2 11/12] nvmet: add error log page cmd handler Chaitanya Kulkarni
2018-12-13 2:52 ` Sagi Grimberg
2018-12-12 23:11 ` [PATCH V2 12/12] nvmet: update smart log with num err log entries Chaitanya Kulkarni
2018-12-13 2:52 ` Sagi Grimberg
2018-12-13 8:54 ` [PATCH V2 00/12] nvmet: add error log page support Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213085243.GA1611@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).