From: ming.lei@redhat.com (Ming Lei)
Subject: [PATCH 1/2] nvme-pci: add module param for io queue number
Date: Wed, 26 Dec 2018 18:23:16 +0800 [thread overview]
Message-ID: <20181226102314.GA32113@ming.t460p> (raw)
In-Reply-To: <1545372253-28025-1-git-send-email-shan.hai@oracle.com>
On Fri, Dec 21, 2018@02:04:12PM +0800, Shan Hai wrote:
> The num_possible_cpus() number of io queues by default would cause
> irq vector shortage problem on a large system when hotplugging cpus,
> add a module parameter to set number of io queues according to the
> system configuration to fix the issue.
>
> Signed-off-by: Shan Hai <shan.hai at oracle.com>
> ---
> drivers/nvme/host/pci.c | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index c33bb20..0d60451 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -64,6 +64,16 @@ MODULE_PARM_DESC(sgl_threshold,
> "Use SGLs when average request segment size is larger or equal to "
> "this size. Use 0 to disable SGLs.");
>
> +static int io_queue_number_set(const char *val, const struct kernel_param *kp);
> +static const struct kernel_param_ops io_queue_number_ops = {
> + .set = io_queue_number_set,
> + .get = param_get_uint,
> +};
> +
> +static unsigned int io_queue_number = UINT_MAX;
> +module_param_cb(io_queue_number, &io_queue_number_ops, &io_queue_number, 0644);
> +MODULE_PARM_DESC(io_queue_number, "set io queue number, should >= 2");
I suggest to name it as 'default_queues', and 'queue_count_ops' can be
reused too.
Thanks,
Ming
prev parent reply other threads:[~2018-12-26 10:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 6:04 [PATCH 1/2] nvme-pci: add module param for io queue number Shan Hai
2018-12-21 6:04 ` [PATCH 2/2] nvme-pci: take the io_queue_number into account when setting number of io queues Shan Hai
2018-12-21 15:02 ` [PATCH 1/2] nvme-pci: add module param for io queue number Bart Van Assche
2018-12-24 1:10 ` Shan Hai
2019-01-04 18:09 ` Christoph Hellwig
2019-01-05 0:18 ` Shan Hai
2018-12-23 0:38 ` Ming Lei
2018-12-24 1:02 ` Shan Hai
2018-12-24 1:47 ` Ming Lei
2018-12-24 2:12 ` Shan Hai
2018-12-24 2:46 ` Ming Lei
2018-12-24 3:05 ` Shan Hai
2018-12-26 10:23 ` Ming Lei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181226102314.GA32113@ming.t460p \
--to=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox