From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] nvme-core: don't initlialize ctrl->cntlid twice
Date: Tue, 8 Jan 2019 08:39:59 -0700 [thread overview]
Message-ID: <20190108153959.GA18014@localhost.localdomain> (raw)
In-Reply-To: <20190108030849.12870-1-andrew.smirnov@gmail.com>
On Mon, Jan 07, 2019@07:08:49PM -0800, Andrey Smirnov wrote:
> ctrl->cntlid will already be initialized from id->cntlid for
> non-NVME_F_FABRICS controllers few lines below. For NVME_F_FABRICS
> controllers this field should already be initialized, otherwise the
> check
>
> if (ctrl->cntlid != le16_to_cpu(id->cntlid))
>
> below will always be a no-op.
Yeah, this bug defeats the fabrics sanity check. Good catch.
Reviewed-by: Keith Busch <keith.busch at intel.com>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 2e65be8b1387..1ec87b30fad1 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -2397,7 +2397,6 @@ int nvme_init_identify(struct nvme_ctrl *ctrl)
> ctrl->oaes = le32_to_cpu(id->oaes);
> atomic_set(&ctrl->abort_limit, id->acl + 1);
> ctrl->vwc = id->vwc;
> - ctrl->cntlid = le16_to_cpup(&id->cntlid);
> if (id->mdts)
> max_hw_sectors = 1 << (id->mdts + page_shift - 9);
> else
> --
next prev parent reply other threads:[~2019-01-08 15:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 3:08 [PATCH] nvme-core: don't initlialize ctrl->cntlid twice Andrey Smirnov
2019-01-08 8:00 ` Sagi Grimberg
2019-01-08 15:39 ` Keith Busch [this message]
2019-01-09 18:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190108153959.GA18014@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox