From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH v2] nvme-rdma: fix timeout handler
Date: Sat, 19 Jan 2019 14:36:01 +0100 [thread overview]
Message-ID: <20190119133601.GA24763@lst.de> (raw)
In-Reply-To: <20190108085734.9681-1-sagi@grimberg.me>
> + if (ctrl->ctrl.state != NVME_CTRL_LIVE) {
> + /*
> + * teardown immediately if controller times out while starting
> + * or we are already started error recovery. all outstanding
> + * requests are completed on shutdown, so we return BLK_EH_DONE.
Nitpick: please start sentences with upper case letters.
Otherwise this looks fine:
Reviewed-by: Christoph Hellwig <hch at lst.de>
next prev parent reply other threads:[~2019-01-19 13:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 8:57 [PATCH v2] nvme-rdma: fix timeout handler Sagi Grimberg
2019-01-08 15:43 ` Keith Busch
2019-01-17 1:27 ` Sagi Grimberg
[not found] ` <CAJX3CtgkGX_1eUU_x=v+VrUwvEA6ZwOgiPdps_-sPc5+JUFBqg@mail.gmail.com>
2019-01-18 2:19 ` Jaesoo Lee
2019-01-19 1:01 ` Sagi Grimberg
2019-01-19 13:36 ` Christoph Hellwig [this message]
2019-01-21 9:12 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190119133601.GA24763@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox