From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@lst.de (Christoph Hellwig) Date: Mon, 21 Jan 2019 14:50:25 +0100 Subject: [PATCH] nvme-multipath: drop optimization for static ANA group IDs In-Reply-To: References: <20190109084515.82076-1-hare@suse.de> <20190119131956.GB24374@lst.de> Message-ID: <20190121135025.GB25858@lst.de> On Mon, Jan 21, 2019@01:23:39AM -0800, Sagi Grimberg wrote: > >> Ok, based on the version that actually keeps the optimization I >> have to say I actually prefer this variant, given that it is a lot >> less code and special cases. Sorry for sending you off the wrong track. >> >> Reviewed-by: Christoph Hellwig > > Oh, so this ends up preferred over v2... I don't have any problem > with allocating for the worse case here... > > Doesn't look like this is urgent for 5.0 rc, shall we queue it > for 5.1? Without it we use unallocate memory if the controller sets bit 6 in anacap. So yes, I think it should go into 5.0 and -stable.