From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme-fc: use pci device as parent for nvme controller
Date: Wed, 23 Jan 2019 08:42:11 +0100 [thread overview]
Message-ID: <20190123074211.GA25386@lst.de> (raw)
In-Reply-To: <4aa44211-8305-7474-9ff4-2f21e620ee21@broadcom.com>
On Sun, Jan 20, 2019@08:38:59AM -0800, James Smart wrote:
>> diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
>> index feb86b59170e..1ecdec6b8b4a 100644
>> --- a/drivers/nvme/host/fc.c
>> +++ b/drivers/nvme/host/fc.c
>> @@ -3117,7 +3117,7 @@ nvme_fc_init_ctrl(struct device *dev, struct nvmf_ctrl_options *opts,
>> * Defer this to the connect path.
>> */
>> - ret = nvme_init_ctrl(&ctrl->ctrl, dev, &nvme_fc_ctrl_ops, 0);
>> + ret = nvme_init_ctrl(&ctrl->ctrl, ctrl->dev, &nvme_fc_ctrl_ops, 0);
>> if (ret)
>> goto out_cleanup_admin_q;
>>
>
> So how do you solve this with rdma and tcp ??? I'm not sure I like
> deviating from them.? Did it pick up the fc-nvme and fabric modules too ?
All fabrics drivers currently use the passed in 'fake' fabrics device.
prev parent reply other threads:[~2019-01-23 7:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 7:42 [PATCH] nvme-fc: use pci device as parent for nvme controller Hannes Reinecke
2019-01-19 13:08 ` Christoph Hellwig
2019-01-21 13:57 ` Hannes Reinecke
2019-01-20 16:38 ` James Smart
2019-01-23 7:42 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123074211.GA25386@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox