2016 Changes to nvme.h

[keith.busch@intel.com (Keith Busch)]

On Thu, Jan 24, 2019@09:38:11PM +0000, Wilson, Ellis wrote:
> Thank you for the response.  I think I understand the intent now.  Your 
> comment about a userspace library makes total sense.  I still disagree 
> with one thing.  You say, "it is just not a good idea to rely on the 
> kernel to own updating the structures when the kernel has no internal 
> need for it."  And yet, those very structures were moved further 
> /inside/, rather than being deleted wholesale, so the action doesn't 
> quite match up with your explanation from what I can tell.

We do have in-kernel uses for nvme structures, hence the relocation to
an internal definition. We just don't want to export it for user space,
which would (and did) create undue maintenance to non-kernel usage.