Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] nvme: Block ns inventory changes during admin
Date: Mon, 28 Jan 2019 08:33:45 -0700	[thread overview]
Message-ID: <20190128153344.GA15271@localhost.localdomain> (raw)
In-Reply-To: <20190128073924.GB3287@lst.de>

On Sun, Jan 27, 2019@11:39:24PM -0800, Christoph Hellwig wrote:
> On Fri, Jan 25, 2019@12:48:19PM -0700, Keith Busch wrote:
> > The driver quiesces IO when the admin command effects say it may alter
> > namespaces.
> > 
> > A device that supports nvme namespace management may trigger a namespace
> > scan automatically. If this changes the namespace inventory by adding
> > more namespace, the driver's unquiesce sequence at the end of sending
> > the admin command may try to unfreeze a queue that isn't frozen,
> > breaking the freeze depth for future use.
> > 
> > Fix that by preventing scan work from altering the namespace list while
> > we are pairing freeze and unfreeze operations.
> 
> Do you have a reference for the bug report?

This was reported internally from Wen. If you prefer, we can open a
public bz sighting and append the kernel logs for a changelog Link:.

  reply	other threads:[~2019-01-28 15:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-25 19:48 [PATCH] nvme: Block ns inventory changes during admin Keith Busch
     [not found] ` <OF5147C249.BC64CC03-ON0025838D.007F28EE-8625838D.007F6785@notes.na.collabserv.com>
2019-01-25 23:37   ` Keith Busch
     [not found]     ` <BYAPR04MB45021C05936FF7EF982D579686940@BYAPR04MB4502.namprd04.prod.outlook.com>
2019-01-28 15:36       ` Keith Busch
2019-01-28  7:39 ` Christoph Hellwig
2019-01-28 15:33   ` Keith Busch [this message]
2019-01-28 15:58     ` Christoph Hellwig
2019-01-28 16:07       ` Keith Busch
2019-01-28 16:30         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190128153344.GA15271@localhost.localdomain \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox