From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] nvme-cli: minor cleanup for sibmit_io()
Date: Tue, 29 Jan 2019 08:46:28 -0700 [thread overview]
Message-ID: <20190129154628.GA17132@localhost.localdomain> (raw)
In-Reply-To: <a9136048-6118-ab5b-72da-9f702ea0c5a4@acm.org>
On Tue, Jan 29, 2019@06:50:56AM -0800, Bart Van Assche wrote:
> On 1/28/19 11:12 PM, Chaitanya Kulkarni wrote:
> > - } else {
> > + } else
> > buffer_size = cfg.data_size;
> > - }
>
> Does nvme-cli follow the kernel coding style? The kernel coding style guide
> explicitly mentions that braces should be balanced. So this patch changes
> codes that conforms to that style guide into code that does not conform.
Yes, kernel is the coding style we try to adhere to for this project. Most
of the changes here are in that direction, so I'll just fix up this one
on the commit.
prev parent reply other threads:[~2019-01-29 15:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 7:12 [PATCH] nvme-cli: minor cleanup for sibmit_io() Chaitanya Kulkarni
2019-01-29 14:50 ` Bart Van Assche
2019-01-29 15:46 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129154628.GA17132@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox