From: keith.busch@intel.com (Keith Busch)
Subject: Question about ioctl interface - IO passthru
Date: Thu, 31 Jan 2019 12:05:11 -0700 [thread overview]
Message-ID: <20190131190510.GA20974@localhost.localdomain> (raw)
In-Reply-To: <BYAPR04MB4502BAB173C20E8B499D633986910@BYAPR04MB4502.namprd04.prod.outlook.com>
On Thu, Jan 31, 2019@06:39:28PM +0000, Chaitanya Kulkarni wrote:
> So I think it is a good start that to use the nvme_passthru command and make it more generic.
>
> Keith any comments on this ?
>
> or should we extend the nvme_user_io command with
> the new addition such as result field (less likely in my?opinion, may break IOCTL)??
Yeah, we can't break the ioctl ABI. :(
The only reason I haven't moved nvme-cli from user_io to passthru is
that user_io works on every nvme capable kernel, and it also supported
metadata long before passthru did. I think it's overdue, though, I'll
just add a new param for ancient-kernel compatibility mode to fallback
to the legacy user_io.
next prev parent reply other threads:[~2019-01-31 19:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 14:09 Question about ioctl interface - IO passthru Eyal BenDavid
2019-01-31 14:55 ` Keith Busch
2019-01-31 18:08 ` Eyal BenDavid
2019-01-31 18:39 ` Chaitanya Kulkarni
2019-01-31 19:05 ` Keith Busch [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-01-31 13:59 Eyal BenDavid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190131190510.GA20974@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox