Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme: Enable acceleration feature of A64FX processor
Date: Thu, 14 Feb 2019 18:11:00 +0100	[thread overview]
Message-ID: <20190214171100.GA473@lst.de> (raw)
In-Reply-To: <20190213120358.GA3559@esprimo>

On Wed, Feb 13, 2019@09:03:58PM +0900, Takao Indoh wrote:
> Ok, let me think about how I should change this patch.

Just drop it.

> I'm thinking that the problem of this patch is adding processor specific
> code into NVMe common driver, is this correct? Or another problem? It
> would be great if you could give me a hint to improve this patch.

For one it is processor / root port specific.  But even more importantly
it is incorrect.  If the device wants to issue a relaxed order
transaction it should do so all by itself, not by hacking around it
from the kernel.

  reply	other threads:[~2019-02-14 17:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-01 12:46 [PATCH] nvme: Enable acceleration feature of A64FX processor Takao Indoh
2019-02-01 14:54 ` Keith Busch
2019-02-05 12:56   ` Takao Indoh
2019-02-05 14:39     ` Keith Busch
2019-02-05 16:13       ` Christoph Hellwig
2019-02-13 12:03         ` Takao Indoh
2019-02-14 17:11           ` Christoph Hellwig [this message]
2019-02-14 20:44       ` Elliott, Robert (Persistent Memory)
2019-02-14 21:17         ` Keith Busch
2019-02-20  9:46         ` Takao Indoh
2019-02-22 17:07           ` Keith Busch
2019-02-01 15:51 ` Christoph Hellwig
2019-02-05 12:56   ` Takao Indoh
2019-02-03  0:17 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190214171100.GA473@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox