From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvmet: disable direct I/O when unavailable
Date: Fri, 8 Mar 2019 14:26:08 +0100 [thread overview]
Message-ID: <20190308132608.GB18218@lst.de> (raw)
In-Reply-To: <71982410-d373-a659-0c0f-8aadf06d1d96@grimberg.me>
On Mon, Feb 25, 2019@01:18:10PM -0800, Sagi Grimberg wrote:
>
>> Frankly, we have a ton of testing related special cases in the kernel.
>>
>> This one is a) simple and small, only 10 LoC, b) far away from the fast
>> path or any other place where it could have any impact on legitimate
>> users and c) it prints an informal message showing you what happened.
>>
>> Sorry but this is a https://xkcd.com/386/ moment.
>
> How about we just fail it with a proper error message and let the
> user set buffered_io instead of trying to get smart here...
Yes, would be my preference.
prev parent reply other threads:[~2019-03-08 13:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 18:22 [PATCH] nvmet: disable direct I/O when unavailable Johannes Thumshirn
2019-02-22 0:41 ` Chaitanya Kulkarni
2019-02-22 5:55 ` Johannes Thumshirn
2019-02-24 10:54 ` Max Gurtovoy
2019-02-25 9:37 ` Johannes Thumshirn
2019-02-25 14:49 ` Bart Van Assche
2019-02-25 15:38 ` Johannes Thumshirn
2019-02-25 16:10 ` Bart Van Assche
2019-02-25 21:18 ` Sagi Grimberg
2019-03-08 13:26 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190308132608.GB18218@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox