From: ming.lei@redhat.com (Ming Lei)
Subject: NVMe: Regression: write zeros corrupts ext4 file system
Date: Tue, 12 Mar 2019 09:32:46 +0800 [thread overview]
Message-ID: <20190312013245.GD28841@ming.t460p> (raw)
In-Reply-To: <20190311145457.GA10411@localhost.localdomain>
On Mon, Mar 11, 2019@08:54:59AM -0600, Keith Busch wrote:
> On Mon, Mar 11, 2019@10:24:42AM +0800, Ming Lei wrote:
> > Hi,
> >
> > It is observed that ext4 is corrupted easily by running some workloads
> > on QEMU NVMe, such as:
> >
> > 1) mkfs.ext4 /dev/nvme0n1
> >
> > 2) mount /dev/nvme0n1 /mnt
> >
> > 3) cd /mnt; git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> >
> > 4) then the following error message may show up:
> >
> > [ 1642.271816] EXT4-fs error (device nvme0n1): ext4_mb_generate_buddy:747: group 0, block bitmap and bg descriptor inconsistent: 32768 vs 23513 free clusters
> >
> > Or fsck.ext4 will complain after running 'umount /mnt'
> >
> > The issue disappears by reverting 6e02318eaea53eaafe6 ("nvme: add support for the
> > Write Zeroes command").
> >
> > QEMU version:
> >
> > QEMU emulator version 2.10.2(qemu-2.10.2-1.fc27)
> > Copyright (c) 2003-2017 Fabrice Bellard and the QEMU Project developers
>
> In QEMU, blk_aio_pwrite_zeroes() takes bytes, but the nvme controller
> thought it was blocks. Oops, that went by unnoticed till now!
>
> We should fix QEMU (patch below). Question is, should we quirk driver
> for older versions too?
I think so, users may never upgrade their QEMU.
Thanks,
Ming
prev parent reply other threads:[~2019-03-12 1:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 2:24 NVMe: Regression: write zeros corrupts ext4 file system Ming Lei
2019-03-11 7:54 ` Dongli Zhang
2019-03-11 10:16 ` Ming Lei
2019-03-11 14:54 ` Keith Busch
2019-03-11 15:23 ` Christoph Hellwig
2019-03-12 1:32 ` Ming Lei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190312013245.GD28841@ming.t460p \
--to=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox