From: kbusch@kernel.org (Keith Busch)
Subject: The state of Compare and Write testing using linux-nvme
Date: Mon, 25 Mar 2019 11:27:25 -0600 [thread overview]
Message-ID: <20190325172725.GB4328@localhost.localdomain> (raw)
In-Reply-To: <CAPrnrPDCNUhXDMaqUTMoMsAsNe7FgvjwHS4+eqpSkOtJVFkkMg@mail.gmail.com>
On Mon, Mar 25, 2019@07:09:11PM +0200, Eyal BenDavid wrote:
> Questions:
> Why the check for flags in the kernel module? The fix is trivial
> (I would suggest a module parameter that can be set from sysfs)
>
> I have a side branch for nvme-cli with the compare and write implemented
> (from two threads), but it?s useless if nvme-core rejects fused flags.
> If it?s desirable I can provide a pull request.
>
> How can a user space program select a specific submission queue?
I think you discovered why we don't allow arbitrary flags. We can't
enforce the user to run in such a way that the commands are submitted in
the correct order on the same queue.
We'd need to provide a new ioctl for fused commands to make this work
correctly.
prev parent reply other threads:[~2019-03-25 17:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 17:09 The state of Compare and Write testing using linux-nvme Eyal BenDavid
2019-03-25 17:27 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325172725.GB4328@localhost.localdomain \
--to=kbusch@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox