From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@lst.de (Christoph Hellwig) Date: Wed, 27 Mar 2019 09:39:52 +0100 Subject: [PATCH 1/4] nvmet: set loop queue's segment boundary mask as PAGE_SIZE - 1 In-Reply-To: References: <20190326031928.9499-1-ming.lei@redhat.com> <20190326031928.9499-2-ming.lei@redhat.com> <20190326073622.GA21617@lst.de> <20190327081508.GE20525@lst.de> Message-ID: <20190327083952.GA21122@lst.de> On Wed, Mar 27, 2019@04:26:26PM +0800, Ming Lei wrote: > On Wed, Mar 27, 2019@4:15 PM Christoph Hellwig wrote: > > > > On Tue, Mar 26, 2019@03:37:36PM +0800, Ming Lei wrote: > > > On Tue, Mar 26, 2019@3:36 PM Christoph Hellwig wrote: > > > > > > > > Note that in many cases allocating larger pages in the other targets > > > > would be useful. Given that you fix the one places where we made a page > > > > size assumption I don't see a great need to limit outselves here. > > > > > > block device backed ns still needs this patch. > > > > Then we need to fix that code as well. Or even better make bio_add_page > > handle the larger than page case fine if it really doesn't do that yet. > > Given loop is the only exception, this patch is exactly the fix, right? Well, we want to be able to pass multi-page biovecs everywhere, so I think we'd just solve this based on loop so that we can later take advantage of it everywhere.